This repository was archived by the owner on May 22, 2025. It is now read-only.
ports update_appearance - #19297
Closed
tattax wants to merge 23 commits into
Closed
Conversation
JohnFulpWillard
suggested changes
Jun 16, 2023
JohnFulpWillard
left a comment
JohnFulpWillard
left a comment
Member
There was a problem hiding this comment.
You have all instances of update_icon set to update_appearance(ALL), which is wrong, it should be UPDATE_ICON
Contributor
Author
not necessarily, no many items configure overlays and whatnot in update_appearance |
tattax
marked this pull request as draft
June 16, 2023 01:25
Member
That's wrong, it should be in |
Contributor
Author
exactly |
tattax
added
Refactor
cuackles
approved these changes
Jun 18, 2023
Merged
Contributor
|
i think it broke pancake stacking but id have to double check, i put a cinnamon pancake on another earlier and it just acted as if the second one never existed wow wrong pr lmao |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just makes it easier to update things, murders update_icon
main pr: tgstation/tgstation#55468
this is more brute force so nothing is fully updated to properly use update_desc, icon, name, but it doesn't really break anything
just encourages people to change it if they find it set up improperly (please)
🆑
imageadd: adds sus airlocks
/:cl: